From 555260e954eb4cc347ba3e7d27c25fe29170cf19 Mon Sep 17 00:00:00 2001
From: Craig Raw <craigraw@gmail.com>
Date: Wed, 8 Feb 2023 08:03:06 +0200
Subject: [PATCH] implement bip329 for importing and exporting wallet labels

---
 drongo                                        |   2 +-
 .../sparrowwallet/sparrow/AppController.java  |  20 +-
 .../sparrow/control/DevicePane.java           |   2 +-
 .../sparrow/control/WalletExportDialog.java   |   4 +-
 .../sparrow/control/WalletImportDialog.java   |   9 +-
 .../event/WalletEntryLabelsChangedEvent.java  |  11 +
 .../sparrow/io/WalletLabels.java              | 296 ++++++++++++++++++
 .../sparrow/wallet/KeystoreController.java    |  25 +-
 .../sparrow/wallet/WalletForm.java            |   3 +-
 src/main/resources/image/labels.png           | Bin 0 -> 979 bytes
 src/main/resources/image/labels@2x.png        | Bin 0 -> 1815 bytes
 src/main/resources/image/labels@3x.png        | Bin 0 -> 4014 bytes
 12 files changed, 359 insertions(+), 13 deletions(-)
 create mode 100644 src/main/java/com/sparrowwallet/sparrow/io/WalletLabels.java
 create mode 100644 src/main/resources/image/labels.png
 create mode 100644 src/main/resources/image/labels@2x.png
 create mode 100644 src/main/resources/image/labels@3x.png

diff --git a/drongo b/drongo
index b4873964..d48054ac 160000
--- a/drongo
+++ b/drongo
@@ -1 +1 @@
-Subproject commit b487396417fbdf3c73c24399a778855c97a26584
+Subproject commit d48054ac6ba071b49180017fe12e3acb41635b9c
diff --git a/src/main/java/com/sparrowwallet/sparrow/AppController.java b/src/main/java/com/sparrowwallet/sparrow/AppController.java
index 0954e47d..d2674f1c 100644
--- a/src/main/java/com/sparrowwallet/sparrow/AppController.java
+++ b/src/main/java/com/sparrowwallet/sparrow/AppController.java
@@ -1068,11 +1068,14 @@ public class AppController implements Initializable {
     }
 
     public void importWallet(ActionEvent event) {
-        WalletImportDialog dlg = new WalletImportDialog();
+        List<WalletForm> selectedWalletForms = getSelectedWalletForms();
+        WalletImportDialog dlg = new WalletImportDialog(selectedWalletForms);
         Optional<Wallet> optionalWallet = dlg.showAndWait();
         if(optionalWallet.isPresent()) {
             Wallet wallet = optionalWallet.get();
-            addImportedWallet(wallet);
+            if(selectedWalletForms.isEmpty() || wallet != selectedWalletForms.get(0).getWallet()) {
+                addImportedWallet(wallet);
+            }
         }
     }
 
@@ -1653,6 +1656,19 @@ public class AppController implements Initializable {
         return null;
     }
 
+    public List<WalletForm> getSelectedWalletForms() {
+        Tab selectedTab = tabs.getSelectionModel().getSelectedItem();
+        if(selectedTab != null) {
+            TabData tabData = (TabData) selectedTab.getUserData();
+            if(tabData instanceof WalletTabData) {
+                TabPane subTabs = (TabPane) selectedTab.getContent();
+                return subTabs.getTabs().stream().map(subTab -> ((WalletTabData) subTab.getUserData()).getWalletForm()).collect(Collectors.toList());
+            }
+        }
+
+        return Collections.emptyList();
+    }
+
     private void addTransactionTab(String name, File file, String string) throws ParseException, PSBTParseException, TransactionParseException {
         if(Utils.isBase64(string) && !Utils.isHex(string)) {
             addTransactionTab(name, file, Base64.getDecoder().decode(string));
diff --git a/src/main/java/com/sparrowwallet/sparrow/control/DevicePane.java b/src/main/java/com/sparrowwallet/sparrow/control/DevicePane.java
index 6d6c9551..4b2df0b9 100644
--- a/src/main/java/com/sparrowwallet/sparrow/control/DevicePane.java
+++ b/src/main/java/com/sparrowwallet/sparrow/control/DevicePane.java
@@ -975,7 +975,7 @@ public class DevicePane extends TitledDescriptionPane {
             }
             importButton.setVisible(true);
             showHideLink.setText("Show derivation...");
-            showHideLink.setVisible(true);
+            showHideLink.setVisible(!device.isCard());
             List<ChildNumber> defaultDerivation = wallet.getScriptType() == null ? ScriptType.P2WPKH.getDefaultDerivation() : wallet.getScriptType().getDefaultDerivation();
             setContent(getDerivationEntry(keyDerivation == null ? defaultDerivation : keyDerivation.getDerivation()));
         } else if(deviceOperation.equals(DeviceOperation.SIGN)) {
diff --git a/src/main/java/com/sparrowwallet/sparrow/control/WalletExportDialog.java b/src/main/java/com/sparrowwallet/sparrow/control/WalletExportDialog.java
index f3e460ff..a160e976 100644
--- a/src/main/java/com/sparrowwallet/sparrow/control/WalletExportDialog.java
+++ b/src/main/java/com/sparrowwallet/sparrow/control/WalletExportDialog.java
@@ -42,9 +42,9 @@ public class WalletExportDialog extends Dialog<Wallet> {
 
         List<WalletExport> exporters;
         if(wallet.getPolicyType() == PolicyType.SINGLE) {
-            exporters = List.of(new Electrum(), new ElectrumPersonalServer(), new Descriptor(), new SpecterDesktop(), new Sparrow());
+            exporters = List.of(new Electrum(), new ElectrumPersonalServer(), new Descriptor(), new SpecterDesktop(), new Sparrow(), new WalletLabels());
         } else if(wallet.getPolicyType() == PolicyType.MULTI) {
-            exporters = List.of(new CaravanMultisig(), new ColdcardMultisig(), new CoboVaultMultisig(), new Electrum(), new ElectrumPersonalServer(), new KeystoneMultisig(), new Descriptor(), new JadeMultisig(), new PassportMultisig(), new SpecterDesktop(), new BlueWalletMultisig(), new SpecterDIY(), new Sparrow());
+            exporters = List.of(new CaravanMultisig(), new ColdcardMultisig(), new CoboVaultMultisig(), new Electrum(), new ElectrumPersonalServer(), new KeystoneMultisig(), new Descriptor(), new JadeMultisig(), new PassportMultisig(), new SpecterDesktop(), new BlueWalletMultisig(), new SpecterDIY(), new Sparrow(), new WalletLabels());
         } else {
             throw new UnsupportedOperationException("Cannot export wallet with policy type " + wallet.getPolicyType());
         }
diff --git a/src/main/java/com/sparrowwallet/sparrow/control/WalletImportDialog.java b/src/main/java/com/sparrowwallet/sparrow/control/WalletImportDialog.java
index eb589b93..0b18ee5c 100644
--- a/src/main/java/com/sparrowwallet/sparrow/control/WalletImportDialog.java
+++ b/src/main/java/com/sparrowwallet/sparrow/control/WalletImportDialog.java
@@ -9,6 +9,7 @@ import com.sparrowwallet.sparrow.event.WalletImportEvent;
 import com.sparrowwallet.sparrow.glyphfont.FontAwesome5;
 import com.sparrowwallet.sparrow.glyphfont.FontAwesome5Brands;
 import com.sparrowwallet.sparrow.io.*;
+import com.sparrowwallet.sparrow.wallet.WalletForm;
 import javafx.application.Platform;
 import javafx.event.ActionEvent;
 import javafx.scene.control.*;
@@ -16,6 +17,7 @@ import javafx.scene.layout.AnchorPane;
 import javafx.scene.layout.StackPane;
 import org.controlsfx.glyphfont.Glyph;
 
+import java.util.ArrayList;
 import java.util.Comparator;
 import java.util.List;
 
@@ -24,7 +26,7 @@ public class WalletImportDialog extends Dialog<Wallet> {
     private final Accordion importAccordion;
     private final Button scanButton;
 
-    public WalletImportDialog() {
+    public WalletImportDialog(List<WalletForm> selectedWalletForms) {
         EventManager.get().register(this);
         setOnCloseRequest(event -> {
             EventManager.get().unregister(this);
@@ -57,7 +59,10 @@ public class WalletImportDialog extends Dialog<Wallet> {
             }
         }
 
-        List<WalletImport> walletImporters = List.of(new CaravanMultisig(), new ColdcardMultisig(), new CoboVaultMultisig(), new Electrum(), new KeystoneMultisig(), new Descriptor(), new SpecterDesktop(), new BlueWalletMultisig(), new Sparrow());
+        List<WalletImport> walletImporters = new ArrayList<>(List.of(new CaravanMultisig(), new ColdcardMultisig(), new CoboVaultMultisig(), new Electrum(), new KeystoneMultisig(), new Descriptor(), new SpecterDesktop(), new BlueWalletMultisig(), new Sparrow()));
+        if(!selectedWalletForms.isEmpty()) {
+            walletImporters.add(new WalletLabels(selectedWalletForms));
+        }
         for(WalletImport importer : walletImporters) {
             if(!importer.isDeprecated() || Config.get().isShowDeprecatedImportExport()) {
                 FileWalletImportPane importPane = new FileWalletImportPane(importer);
diff --git a/src/main/java/com/sparrowwallet/sparrow/event/WalletEntryLabelsChangedEvent.java b/src/main/java/com/sparrowwallet/sparrow/event/WalletEntryLabelsChangedEvent.java
index ae0f6759..7f766286 100644
--- a/src/main/java/com/sparrowwallet/sparrow/event/WalletEntryLabelsChangedEvent.java
+++ b/src/main/java/com/sparrowwallet/sparrow/event/WalletEntryLabelsChangedEvent.java
@@ -11,22 +11,29 @@ import java.util.*;
 public class WalletEntryLabelsChangedEvent extends WalletChangedEvent {
     //Contains the changed entry mapped to the entry that changed it, if changed recursively (otherwise null)
     private final Map<Entry, Entry> entrySourceMap;
+    private final boolean propagate;
 
     public WalletEntryLabelsChangedEvent(Wallet wallet, Entry entry) {
         this(wallet, List.of(entry));
     }
 
     public WalletEntryLabelsChangedEvent(Wallet wallet, List<Entry> entries) {
+        this(wallet, entries, true);
+    }
+
+    public WalletEntryLabelsChangedEvent(Wallet wallet, List<Entry> entries, boolean propagate) {
         super(wallet);
         this.entrySourceMap = new LinkedHashMap<>();
         for(Entry entry : entries) {
             entrySourceMap.put(entry, null);
         }
+        this.propagate = propagate;
     }
 
     public WalletEntryLabelsChangedEvent(Wallet wallet, Map<Entry, Entry> entrySourceMap) {
         super(wallet);
         this.entrySourceMap = entrySourceMap;
+        this.propagate = true;
     }
 
     public Collection<Entry> getEntries() {
@@ -36,4 +43,8 @@ public class WalletEntryLabelsChangedEvent extends WalletChangedEvent {
     public Entry getSource(Entry entry) {
         return entrySourceMap.get(entry);
     }
+
+    public boolean propagate() {
+        return propagate;
+    }
 }
diff --git a/src/main/java/com/sparrowwallet/sparrow/io/WalletLabels.java b/src/main/java/com/sparrowwallet/sparrow/io/WalletLabels.java
new file mode 100644
index 00000000..13faf217
--- /dev/null
+++ b/src/main/java/com/sparrowwallet/sparrow/io/WalletLabels.java
@@ -0,0 +1,296 @@
+package com.sparrowwallet.sparrow.io;
+
+import com.google.gson.Gson;
+import com.sparrowwallet.drongo.KeyPurpose;
+import com.sparrowwallet.drongo.OutputDescriptor;
+import com.sparrowwallet.drongo.wallet.*;
+import com.sparrowwallet.sparrow.AppServices;
+import com.sparrowwallet.sparrow.EventManager;
+import com.sparrowwallet.sparrow.event.KeystoreLabelsChangedEvent;
+import com.sparrowwallet.sparrow.event.WalletEntryLabelsChangedEvent;
+import com.sparrowwallet.sparrow.wallet.*;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.*;
+import java.nio.charset.StandardCharsets;
+import java.util.*;
+
+public class WalletLabels implements WalletImport, WalletExport {
+    private static final Logger log = LoggerFactory.getLogger(WalletLabels.class);
+
+    private final List<WalletForm> walletForms;
+
+    public WalletLabels() {
+        this.walletForms = Collections.emptyList();
+    }
+
+    public WalletLabels(List<WalletForm> walletForms) {
+        this.walletForms = walletForms;
+    }
+
+    @Override
+    public boolean isEncrypted(File file) {
+        return false;
+    }
+
+    @Override
+    public String getName() {
+        return "Wallet Labels";
+    }
+
+    @Override
+    public WalletModel getWalletModel() {
+        return WalletModel.LABELS;
+    }
+
+    @Override
+    public void exportWallet(Wallet wallet, OutputStream outputStream) throws ExportException {
+        List<Label> labels = new ArrayList<>();
+        List<Wallet> allWallets = wallet.isMasterWallet() ? wallet.getAllWallets() : wallet.getMasterWallet().getAllWallets();
+        for(Wallet exportWallet : allWallets) {
+            OutputDescriptor outputDescriptor = OutputDescriptor.getOutputDescriptor(exportWallet);
+            String origin = outputDescriptor.toString(true, false, false);
+
+            for(Keystore keystore : exportWallet.getKeystores()) {
+                if(keystore.getLabel() != null && !keystore.getLabel().isEmpty()) {
+                    labels.add(new Label(Type.xpub, keystore.getExtendedPublicKey().toString(), keystore.getLabel(), null));
+                }
+            }
+
+            for(BlockTransaction blkTx : exportWallet.getWalletTransactions().values()) {
+                if(blkTx.getLabel() != null && !blkTx.getLabel().isEmpty()) {
+                    labels.add(new Label(Type.tx, blkTx.getHashAsString(), blkTx.getLabel(), origin));
+                }
+            }
+
+            for(WalletNode addressNode : exportWallet.getWalletAddresses().values()) {
+                if(addressNode.getLabel() != null && !addressNode.getLabel().isEmpty()) {
+                    labels.add(new Label(Type.addr, addressNode.getAddress().toString(), addressNode.getLabel(), null));
+                }
+            }
+
+            for(BlockTransactionHashIndex txo : exportWallet.getWalletTxos().keySet()) {
+                if(txo.getLabel() != null && !txo.getLabel().isEmpty()) {
+                    labels.add(new Label(Type.output, txo.toString(), txo.getLabel(), null));
+                }
+
+                if(txo.isSpent() && txo.getSpentBy().getLabel() != null && !txo.getSpentBy().getLabel().isEmpty()) {
+                    labels.add(new Label(Type.input, txo.getSpentBy().toString(), txo.getSpentBy().getLabel(), null));
+                }
+            }
+        }
+
+        try {
+            Gson gson = new Gson();
+            BufferedWriter writer = new BufferedWriter(new OutputStreamWriter(outputStream, StandardCharsets.UTF_8));
+
+            for(Label label : labels) {
+                writer.write(gson.toJson(label) + "\n");
+            }
+
+            writer.flush();
+        } catch(Exception e) {
+            log.error("Error exporting labels", e);
+            throw new ExportException("Error exporting labels", e);
+        }
+    }
+
+    @Override
+    public String getWalletExportDescription() {
+        return "Exports a file containing labels from this wallet in the BIP329 standard format.";
+    }
+
+    @Override
+    public String getExportFileExtension(Wallet wallet) {
+        return "jsonl";
+    }
+
+    @Override
+    public boolean isWalletExportScannable() {
+        return false;
+    }
+
+    @Override
+    public boolean walletExportRequiresDecryption() {
+        return false;
+    }
+
+    @Override
+    public String getWalletImportDescription() {
+        return "Imports a file containing labels in the BIP329 standard format to the currently selected wallet.";
+    }
+
+    @Override
+    public Wallet importWallet(InputStream inputStream, String password) throws ImportException {
+        if(walletForms.isEmpty()) {
+            throw new IllegalStateException("No wallets to import labels for");
+        }
+
+        Gson gson = new Gson();
+        List<Label> labels = new ArrayList<>();
+        try {
+            BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream, StandardCharsets.UTF_8));
+            String line;
+            while((line = reader.readLine()) != null) {
+                Label label;
+                try {
+                    label = gson.fromJson(line, Label.class);
+                } catch(Exception e) {
+                    continue;
+                }
+
+                if(label == null || label.type == null || label.ref == null || label.label == null || label.label.isEmpty()) {
+                    continue;
+                }
+
+                labels.add(label);
+            }
+        } catch(Exception e) {
+            throw new ImportException("Error importing labels file", e);
+        }
+
+        Map<Wallet, List<Keystore>> changedWalletKeystores = new LinkedHashMap<>();
+        Map<Wallet, List<Entry>> changedWalletEntries = new LinkedHashMap<>();
+
+        for(WalletForm walletForm : walletForms) {
+            Wallet wallet = walletForm.getWallet();
+            if(!wallet.isValid()) {
+                continue;
+            }
+
+            OutputDescriptor outputDescriptor = OutputDescriptor.getOutputDescriptor(wallet);
+            String origin = outputDescriptor.toString(true, false, false);
+
+            List<Entry> transactionEntries = walletForm.getWalletTransactionsEntry().getChildren();
+            List<Entry> addressEntries = new ArrayList<>();
+            addressEntries.addAll(walletForm.getNodeEntry(KeyPurpose.RECEIVE).getChildren());
+            addressEntries.addAll(walletForm.getNodeEntry(KeyPurpose.CHANGE).getChildren());
+            List<Entry> utxoEntries = walletForm.getWalletUtxosEntry().getChildren();
+
+            for(Label label : labels) {
+                if(label.origin != null && !label.origin.equals(origin)) {
+                    continue;
+                }
+
+                if(label.type == Type.xpub) {
+                    for(Keystore keystore : wallet.getKeystores()) {
+                        if(keystore.getExtendedPublicKey().toString().equals(label.ref)) {
+                            keystore.setLabel(label.label);
+                            List<Keystore> changedKeystores = changedWalletKeystores.computeIfAbsent(wallet, w -> new ArrayList<>());
+                            changedKeystores.add(keystore);
+                        }
+                    }
+                }
+
+                if(label.type == Type.tx) {
+                    for(Entry entry : transactionEntries) {
+                        if(entry instanceof TransactionEntry transactionEntry) {
+                            BlockTransaction blkTx = transactionEntry.getBlockTransaction();
+                            if(blkTx.getHashAsString().equals(label.ref)) {
+                                transactionEntry.getBlockTransaction().setLabel(label.label);
+                                transactionEntry.labelProperty().set(label.label);
+                                addChangedEntry(changedWalletEntries, entry);
+                            }
+                        }
+                    }
+                }
+
+                if(label.type == Type.addr) {
+                    for(Entry addressEntry : addressEntries) {
+                        if(addressEntry instanceof NodeEntry nodeEntry) {
+                            WalletNode addressNode = nodeEntry.getNode();
+                            if(addressNode.getAddress().toString().equals(label.ref)) {
+                                nodeEntry.getNode().setLabel(label.label);
+                                nodeEntry.labelProperty().set(label.label);
+                                addChangedEntry(changedWalletEntries, addressEntry);
+                            }
+                        }
+                    }
+                }
+
+                if(label.type == Type.output || label.type == Type.input) {
+                    for(Entry entry : transactionEntries) {
+                        for(Entry hashIndexEntry : entry.getChildren()) {
+                            if(hashIndexEntry instanceof TransactionHashIndexEntry txioEntry) {
+                                BlockTransactionHashIndex reference = txioEntry.getHashIndex();
+                                if((label.type == Type.output && txioEntry.getType() == HashIndexEntry.Type.OUTPUT && reference.toString().equals(label.ref))
+                                        || (label.type == Type.input && txioEntry.getType() == HashIndexEntry.Type.INPUT && reference.toString().equals(label.ref))) {
+                                    txioEntry.getHashIndex().setLabel(label.label);
+                                    txioEntry.labelProperty().set(label.label);
+                                    addChangedEntry(changedWalletEntries, txioEntry);
+                                }
+                            }
+                        }
+                    }
+                    for(Entry addressEntry : addressEntries) {
+                        for(Entry entry : addressEntry.getChildren()) {
+                            updateHashIndexEntryLabel(label, entry);
+                            for(Entry spentEntry : entry.getChildren()) {
+                                updateHashIndexEntryLabel(label, spentEntry);
+                            }
+                        }
+                    }
+                    for(Entry entry : utxoEntries) {
+                        updateHashIndexEntryLabel(label, entry);
+                    }
+                }
+            }
+        }
+
+        for(Map.Entry<Wallet, List<Keystore>> walletKeystores : changedWalletKeystores.entrySet()) {
+            Wallet wallet = walletKeystores.getKey();
+            Storage storage = AppServices.get().getOpenWallets().get(wallet);
+            EventManager.get().post(new KeystoreLabelsChangedEvent(wallet, wallet, storage.getWalletId(wallet), walletKeystores.getValue()));
+        }
+
+        for(Map.Entry<Wallet, List<Entry>> walletEntries : changedWalletEntries.entrySet()) {
+            EventManager.get().post(new WalletEntryLabelsChangedEvent(walletEntries.getKey(), walletEntries.getValue(), false));
+        }
+
+        return walletForms.get(0).getWallet();
+    }
+
+    private static void updateHashIndexEntryLabel(Label label, Entry entry) {
+        if(entry instanceof HashIndexEntry hashIndexEntry) {
+            BlockTransactionHashIndex reference = hashIndexEntry.getHashIndex();
+            if((label.type == Type.output && hashIndexEntry.getType() == HashIndexEntry.Type.OUTPUT && reference.toString().equals(label.ref))
+                    || (label.type == Type.input && hashIndexEntry.getType() == HashIndexEntry.Type.INPUT && reference.toString().equals(label.ref))) {
+                hashIndexEntry.labelProperty().set(label.label);
+            }
+        }
+    }
+
+    private static void addChangedEntry(Map<Wallet, List<Entry>> changedEntries, Entry entry) {
+        List<Entry> entries = changedEntries.computeIfAbsent(entry.getWallet(), wallet -> new ArrayList<>());
+        entries.add(entry);
+    }
+
+    @Override
+    public boolean isWalletImportScannable() {
+        return false;
+    }
+
+    @Override
+    public boolean exportsAllWallets() {
+        return true;
+    }
+
+    private enum Type {
+        tx, addr, pubkey, input, output, xpub
+    }
+
+    private static class Label {
+        public Label(Type type, String ref, String label, String origin) {
+            this.type = type;
+            this.ref = ref;
+            this.label = label;
+            this.origin = origin;
+        }
+
+        Type type;
+        String ref;
+        String label;
+        String origin;
+    }
+}
diff --git a/src/main/java/com/sparrowwallet/sparrow/wallet/KeystoreController.java b/src/main/java/com/sparrowwallet/sparrow/wallet/KeystoreController.java
index 22b9e1e4..5a26edc5 100644
--- a/src/main/java/com/sparrowwallet/sparrow/wallet/KeystoreController.java
+++ b/src/main/java/com/sparrowwallet/sparrow/wallet/KeystoreController.java
@@ -13,6 +13,7 @@ import com.sparrowwallet.sparrow.io.CardApi;
 import com.sparrowwallet.sparrow.io.Storage;
 import com.sparrowwallet.sparrow.keystoreimport.KeystoreImportDialog;
 import javafx.application.Platform;
+import javafx.beans.value.ChangeListener;
 import javafx.concurrent.Service;
 import javafx.event.ActionEvent;
 import javafx.fxml.FXML;
@@ -96,6 +97,11 @@ public class KeystoreController extends WalletFormController implements Initiali
 
     private final ValidationSupport validationSupport = new ValidationSupport();
 
+    private final ChangeListener<String> labelChangeListener = (observable, oldValue, newValue) -> {
+        keystore.setLabel(newValue);
+        EventManager.get().post(new SettingsChangedEvent(walletForm.getWallet(), SettingsChangedEvent.Type.KEYSTORE_LABEL));
+    };
+
     @Override
     public void initialize(URL location, ResourceBundle resources) {
         EventManager.get().register(this);
@@ -152,10 +158,7 @@ public class KeystoreController extends WalletFormController implements Initiali
             keystore.setKeyDerivation(new KeyDerivation("",""));
         }
 
-        label.textProperty().addListener((observable, oldValue, newValue) -> {
-            keystore.setLabel(newValue);
-            EventManager.get().post(new SettingsChangedEvent(walletForm.getWallet(), SettingsChangedEvent.Type.KEYSTORE_LABEL));
-        });
+        label.textProperty().addListener(labelChangeListener);
         fingerprint.textProperty().addListener((observable, oldValue, newValue) -> {
             keystore.setKeyDerivation(new KeyDerivation(newValue, keystore.getKeyDerivation().getDerivationPath()));
             fingerprintIcon.setHex(newValue.length() == 8 ? newValue : null);
@@ -597,4 +600,18 @@ public class KeystoreController extends WalletFormController implements Initiali
             }
         }
     }
+
+    @Subscribe
+    public void keystoreLabelsChanged(KeystoreLabelsChangedEvent event) {
+        if(event.getWalletId().equals(walletForm.getWalletId())) {
+            for(Keystore changedKeystore : event.getChangedKeystores()) {
+                if(xpub.getText().trim().equals(changedKeystore.getExtendedPublicKey().toString()) && !label.getText().equals(changedKeystore.getLabel())) {
+                    label.textProperty().removeListener(labelChangeListener);
+                    label.setText(changedKeystore.getLabel());
+                    keystore.setLabel(changedKeystore.getLabel());
+                    label.textProperty().addListener(labelChangeListener);
+                }
+            }
+        }
+    }
 }
diff --git a/src/main/java/com/sparrowwallet/sparrow/wallet/WalletForm.java b/src/main/java/com/sparrowwallet/sparrow/wallet/WalletForm.java
index 41db2325..9f014683 100644
--- a/src/main/java/com/sparrowwallet/sparrow/wallet/WalletForm.java
+++ b/src/main/java/com/sparrowwallet/sparrow/wallet/WalletForm.java
@@ -488,7 +488,8 @@ public class WalletForm {
     public void walletLabelsChanged(WalletEntryLabelsChangedEvent event) {
         if(event.toThisOrNested(wallet)) {
             Map<Entry, Entry> labelChangedEntries = new LinkedHashMap<>();
-            for(Entry entry : event.getEntries()) {
+            Collection<Entry> entries = event.propagate() ? event.getEntries() : Collections.emptyList();
+            for(Entry entry : entries) {
                 if(entry.getLabel() != null && !entry.getLabel().isEmpty()) {
                     if(entry instanceof TransactionEntry transactionEntry) {
                         for(KeyPurpose keyPurpose : KeyPurpose.DEFAULT_PURPOSES) {
diff --git a/src/main/resources/image/labels.png b/src/main/resources/image/labels.png
new file mode 100644
index 0000000000000000000000000000000000000000..6d78b4a96cfc32c34b53926221b05b10f8676177
GIT binary patch
literal 979
zcmeAS@N?(olHy`uVBq!ia0vp^Mj*_=1|;R|J2nC-#^NA%Cx&(BWL^R}E~ycoX}-P;
zT0k}j17mw80}DtA5K93u0|WB{Mh0de%?J`(zyy~yTEL88gA|sYUcVYh$z;0thX83N
zkQfk10<i{^2C^An^X*!A7f5gSba4#HV0|;~w3ch4$Z`IqPwG4;Me9jcFbAtG`^0k3
z!86WLO>N$RBPY&G@o-Y%VtynuvAv-4zE*tL>b>Xpy}$T<ef{s~`}bb&zgGYCZLQzZ
zM-SB>z@dO;W7xci_VN#=YVj5Cc-9>h%P>59jPp)=@V7L<Lgq#7AJm!GpM2XcwVTE7
z^W4&hY0p9(!!6E!m6Od)yZmCGp#Pym8=8t{9cwPyB5AqK-7UKBt%VLt(Xr-PUb~l{
z-LkMY=gZT(Qq4OT&zqRP>goe^pCq5znd;$jRdeH&<yv<tojG9~dS|9wS}k{}abR}t
zvgSL%ll6Zo8<@99MjDBVbu6B>{rlFLexJ_w9uxj3aE3L}O|18q%*I?3zcpt|78Yif
z$aS(OrnN{;)c5;5ze@PJt;F(=3(~jD%qv;fbB*~U!<iNX<x2sg?;JEmt|Uyd&0WTB
z`&01hPw^vp1v--#&l8N*=-+B~*?YBl!0SBK{QvfgeUvY4F}v&@(|WF_=9zke)|6bA
zS<~#7e|p57w!m2FI`2)N=F~}B0wQ1MUVYQ}%F$=pA)Uxn)Ag@w0>bMwSXW=T`#b5b
z#%#wQtPBkQ|Mw-P+yq8p5GV?h6AtjsXb2K-`0<}1fqBJdrHgOGTDvCutYj+P<6zt)
zCpWoumx=7zJiZkckyF$H#BFVh`A$y#+>jG-V6T&q`fN}A^M6=&UEq4<m8kGnup?0}
zl1p^?j73}1>lkBS^glV3>R@(8Sm74CXJ3-qTASu~oqQ(#bC%qA8o{$*Tlxjti%riu
z&pYfh6DtpJ?TDJ^_}xW$mU<oY&$^I8Lpf)SuROcdUtO^I$bN$Vc(Q%y(i0$oRU0dq
zLL@JVPIx6*;y;BswmZh^FYBk|7q6IAPIrJ5cx|Xq;yZbVF;VCfkjHh=<|F?Je;I-4
z$s0wU%w%`ynG@phM&F?)W+Cf>m5h~2k{#@#514ncO?g+&@Uc$e9a~bRf*af9MwuDu
zj`KX6r^$Hb2ro#!&-9UB!B5tU@A$JYvjqy`W}Sf>FA7NTHbRL7<s1wQOK$u;C;qg@
R7norfJYD@<);T3K0RWRihSmT8

literal 0
HcmV?d00001

diff --git a/src/main/resources/image/labels@2x.png b/src/main/resources/image/labels@2x.png
new file mode 100644
index 0000000000000000000000000000000000000000..2ede6026dd610d403571d41608e6ed2677e97a92
GIT binary patch
literal 1815
zcma)*do<MR8pp>BLuST7c8yzOk7@RhV&sw<Wo|LV{1_ES6wNSl8QZ-~#+^;&(ztIL
z6V@oX9hZt#adrmf5|WT(=PpA@M~a-Ewaz-{zq8J}*7yB9&-*;j`#yiX&u@T}ElOES
z83KWz7<M!lknCM4!NEP`eXc7AxiA-73Z$k_XAyL095;rqqa(x+w3Q%oss0f8-4sw-
zpdb*KNDcx6DYttjg8nDU7Qy~&?<N|zPLe_B_|urXk3e_Nz-0=G@Na@PtV9xd^c_fl
z294|*Ew^0cC{b}nOKTm<M@Q@H>Hr)L$7oUAJkwBTBNQ&At2<+z?X&Gh_Vsl7ISWf}
zzOG=Gg}>;Gdh&GBI-@0c==XV2*eXB9X}h)8%Fp*l|BhwUT*>Dro}QB=Ip(vyALajF
zpzWdWmfN&EX;H5dq2YHfd!1Gsa1}P)yp-w{uI)+J1`dsz-CLpx97Y`bEEU|xQFy$y
zmxx#J1>#s>x%V~(Xc%Z{J{7vslp@MAIN$-}XwXlxln*0%c%(qeUr%(2=H}a)!&sfo
zw&}yrt{5XYC!_tt+e&%N+EppQo@@`04vB8G2Rv<GT?FbK7X-ls08y7lM5Xh;M*Dx{
zr(4|&Tn+K0NvPJ9aL)14i`x7<f!OTFP&JX3#wPn~CuEj3BpTMVL-rVT#0JELRx^Ml
z6&##n;q7td*q{a>&u6eyF|_qza!uKOLXcDG^)Xq1%DjO0F{Hq%iRT`_B^GaUXX1L;
zsK7(tZmcC`k@Dc21M|(*7CJs&4?NE4oyfg%&Lj^>Tn$3?@cVf2SVVDCkb4}dB7GF=
zrD<HGB~*wOHr0<N*VWe08X)yX4$H(OHN*?k8nSy@Die;0`Ji+Vku{wHZPrYvlMgPu
zOI~bGoh@u02Uu0C2FRn}kjNCPJd@8wcggNa`Nr^5t;mR63$O(9u&DZ&wzObYW@U^n
zndSm{Q;Ua|UZS?&l?|U=0`}>-ywo>4`TS3}Z!2X$JAESn$b0|6<BxGn=j{Eo9<X)w
z>aG1c^bF^}<S>o4B?|+WrEf$=(tm8E*}fI%-fKj`?TiWxrRIb~jN@>6Fz@I++@OVC
zD3J?{m>lV+$i!DWzH(g|0s2{JjZN}%W;wYkkl66R#s?UI(SF>f05c=za=DXZNF2N(
zzmaNF{xpZDGp<q&<6NF{$;T`ui@NeJ!p=9rQoCBd3n19|7e}d+6SsrZb;qc&XG2rP
zEf;@H82D+hId;=KsTz+PKX{zdRO;Y#<l6UoA3VFEd)vQX;c7eT_3(MKxS3D21YZii
zc)~a;X@#b=_Pf%9sP2rJkAG}YEG@&<@roq$Y8XrXx@5+L$cb(IfB|Q3XXms|sRW$K
zncbn274|#0I%`N@BOA{)s;Q~tlo8=S`=AZgu@u^SF>Zn&(NIbr#HuQgRWB?Erm!LT
z+8ci#sByfXU~!nDCafMF6fegl#S{CiH%vdrPHap*3JD>tPJCb4=Fj!MY^@cG8_#6~
zd!!8^pX<Y4r_}w}S9x-HIL)NcEWPLww+4Y6EBrRVy5EsBi05RLJu;}?*~h|MyQl2u
zwilm^H+X|CT1{?xL;R9m-k>)Nqpq2T3REYGS5B}n{)RG_PIOTw%G3@ht;!_jo-^Q)
z*Pzs+sX9>+KyZ9j=D}PGgK^R5v#e!$A1-mNeyhW0?rNTWhETV94*$0<hptyq>5MMh
zO6GD^xdX9VBLDV$0y1YE7x^t^5AJL_1AaJ6!TYf(VMmkPik@sPXJoUD5*u)dw@@(w
zVy+J(8{6#`n)T^1w|DaCx~FnC*8;den~db}DZM{Y1-zjr_SrSa$9L+wN2$FLyebd;
zT(JhDvn}z)_2EYMk>zdgi{*BvzPfBa{pNYgxY>eCk96F0MdA&fWRaj4mwA0U2iqO}
zr(R-YDDS(HS(+97Fg=GT)0>8vmynGn=859n_?+Ifs=4RML}X~Nw?j7jj8)e$iX$@%
z;nd;g4K_@Q5R%7bg@NSVSVEnwa#iulitixpl{gWsMoTw;U~xa6`n9c=>s1)*UZauY
zJytB9pSIAHN*4PY<$OO?*n^jZ3yIHO+OqU)m<wEH_djnP;jgz*gY**u)~6N_V&KKL
zb^E873x2&Nzl136%&F?odSqB%RdXfQ-3KZxLC+3l!ZKon#GEo5yqjhvZ*6w%*1~C5
z{XiL9`3%Lb6E+UHMv8{=OlEdmV)ZRGwyMHu`=MV5J^IQn3yN{Eeh;${k1F>}w_uN?
v@DJ#E?IFk=6v+$Y)B&iy&Hr$|I!<9wCG)oxmw2zhj}KwcooF?bO9}r1a;6mT

literal 0
HcmV?d00001

diff --git a/src/main/resources/image/labels@3x.png b/src/main/resources/image/labels@3x.png
new file mode 100644
index 0000000000000000000000000000000000000000..0ce8956417830506c4b96fb4c4336eee5f1756c7
GIT binary patch
literal 4014
zcmdT_2Uk;Fvksw4QM!Zxc`=4iB~ictN(&_rq)3;S4l0N-M8F7w5D=*vLX}=bdNpbg
z5RpzO(ghTyNw0z+0ynI6*S&w?`_4LZo;lCVp4ofWtUXa?*9>@0fldJc03M7X+Jb={
zC&IzT_?FvNWHEq=U}2yGsOSYRGJen=wir(n6M!s3=KwH8-UhIoxG)675CDKVhY7&U
zK&BHe2l#*1jvVIy*H0YNZ(K=Y0QffA)RKX~6OQq?GX(y>$k5q$hK#LWGVmh?t!?>$
zX(co8X_DUAwqfl196Q%!4<iw1bA{Qy>0(IIzek*MNOIm8pv)<`DB;9rMSDKOP!^%Y
zfAj>!EcCrU^B7fkz(?LF8I{DHiiS@-lyKGN&AhVRu-zMwwod$^7Z5O?nKq@-mqlpA
z^?t$62ueYK{{`>!Cru8C4X0=zqNcB|uJ4t38XHk=%VPG9yA>YH<`}=C`z>@fh*wV*
zWaKP6&u|pmH`S-HdlNZ`Y&Ef|@!DDXM{z5&mt)t<(Xt@4v&MWKa9^N?pi4OT<5z}f
zLRw`!Zr1H^oXj#v#}vbI>w;MdbB5$P9K~J?_8C-tlO_kX{E8)+-C;*24tL)Qtoq4f
z*`3mKDe-_qv@VxM6>Ay)sV>#<t!eB0FER$K`muBfEeO(@hyBT0-WTOo)Oy$=2Di8$
z^d^L_^U!SQX_Gy@wI&U<yU!ypj9TI8@tmt=edNI(X|e%FoYp%++pAt|50-#^k?c&o
zFuAX$Z;oJc45ORRR(nS)cRI3H^yNLlTI6cSw~U2czT;kYc6nU04Qh(QKVtKPL4<_P
z*hV9kWqa%B-ChX<@Rxx*NDM0*u^BJ0EVUrGUG*Y7V5MRHQ=oEvR4JU?<R3dn4W*4%
zr-oNbs;DEsh1(-JA&Ek?%vvKKix|uUT5^g{!+e{;qqG8OWYFR}yd$tEP`niLfVtn>
zN6dJ@U^$YkeJ78a8g5|tAhD$z`i$z>a31hndnJs)N&8<pO}c6krf+{GoZD5ELz1%$
zwrJo~X^_BEZhddMwHvajLrrx@?)sJHV<fO;l#%2V?P(s@M^F??Nnp=s=(2t3bU0Uv
zb`ZC#GUpVfkwN{24H?N9cSC~Ns$a}1!PiX;C}p=_CI~3lvu!Fr9fn4_g<LUJ{&jx9
zc)2Ut=S<^zc;EYV9mhzAuzJ=`x337CQl8RsVzS8ErOt`?<#%FKK{87hl0$QA9zR>{
zMo+n5k29Ee6^y~`<%+ID8tA=F=x7e0$JtpCIu0L-%8GqM%iya`b(bAEmKf-UmY%Az
z8RP{P^EAJ*<Wg_r-ru@)=?`e}e1hz<E!LN1<S2CJ4^CGhB2>$Zv~f<Q9IvPr4=ELV
zJ31yz!G0Royzii?8Ej?#T+4{G!S^^I)@>Sff0zIEu%A5a$Bn#z%Sc<%T2Y^s^Z|&s
z_+v$MTuH<#s<9Pn5c=_&0k3L)vee1S49Uxp)h{;1i9zIbnSl~-J1kP1+aHDhJ~$#|
zs0Rp5WJ}{y3O1xX`&{H@9{3E0;3Ni5w}ioHoW%>;keAwf6I18d%vx^b_!Zqma8|B8
zT52J|XiUXtNsQp&i*4`pf@jY^RZGny@CsAtEcJcQGpX`UgV1hrv?7ZIXtr6=O?Y3W
zGRz#E+=DZcWb}>H4}!F!##|M5@t!15hNrnNJUTAMJV!?7S=y^sXl>Ixm-N+3om4|T
zcE;xRncOzV(AfIuUPQCEg;NYBo;_PzTK~ZOC#YZ=z*w$>zk099R_{2FPwf)sy99yJ
zGb)#ftLIE=3KsO|CckmrQN_msz9q3emd@={s=4ts;{y)S39bV9PVa~;+3s?G-HI7v
z%Y9CC-fROd^y*IF$f)$3(Q$cL8keUdyT<K=?&sytklaYwC&B$!3Eb25@_*q8Pe7}K
z^C1c_6yM6O+U9|{pD^TxxChAHa;5&s2R<68(`{^-jQfXp-s5%L(c!a*R%noBkLoq~
z5OgN7V?<wwjl36gC{>j@D+nK7zP)tDYts@hr^_Y-8!4gtAUH#|Ln42rZgZ92XBSo=
z?QwMIhBtUIdPa8lK{f?rPXyYs-HzA31&P62)BUh6j%^lMEf2gRMY_}tv8K=?-w|ta
zNAoQ!vvGQH))CzN7hX8#8Eq1}&vh=EsZ<)Z_Ws;bL7~~AM6hMw%MKM_KOPnRFr=(#
zA7gwFQQQL#q<&jr%0>b3z%H&cxSW`u#LX|Ac$Q4uVH6jE?wx^-pf)_$AGq)SLmJa_
z6|#vA7N$&c`nA*NqF26#vUWl6Qc--V0aJOfw8w{2!Y=%~Jy+eI2XX6s5>oC2|N3#r
z6Jtm8?_DOao0ViSVzjvMS=v1cju`4yguK1_n%b*yVCt2qy)s=DT@o9tK~lch5B<w!
zGm`#voh|<Jm?zROi!GNkW^!juH!udje<>y#o$a&I)+O&e^h$KHg4c45`*m%j`D#KF
z0`z6&5#8RkFXf}n*i=+#*NUo_%fHTt`YIE5!lkY&w_6%BC(-Cd5v!p)VqaDy&IyVZ
zpx8t?Ea&C(g?Cv;aPGBw`f#Knfg2fig}1>8ack&PqJD{{^8n>DEaii&+@Qaz&qB<O
zf<7rjD2Ljn^2I$|O50z={p*+pxTyCa)*ilNH1dHl(~pm%1)|y*!~ERIFkj8|?(nz{
zZkrMX%>=7rJzdX|CkKMQlgLthG<1i8D@@>gLE${f!mA+BSB7>?=DZQ5x&IyX6EwjX
zJ>!>&kPLF3Bp$_42D1*cYDWmW#G6jRrAO<io7vPO@71Y?Spn;W-bO4Ii$hs|J=A^u
z;^Pt;qk!<chj%?{vkn|#Au;ZRK95Iv$P3DT_e@U68#!bg;)ip>pY&M@+9S)`>w96#
z-?$3@d`@=K&=f=xD!Z+7o!MAmTeWfgIt+rfz)|Xxi|D2F{SO+5keSk+0Z_fWPBU~z
zxzjDGtG*}WV4HvYZQi(|eT)s(EVUpDMmukwb~<gl@iHRByTm2o;i<2O?62YGY2GFz
zx-osK#4EKx9JX&?l984}A8R<$BYQXR?Gp5Lj;yUeLifWug~r}3Ph}R-DOP==-H}oI
zH*WAy9yH@yto_n83%d5Bx*UohUOO&jWUT|iHd|&mD!Noo!%C3;WEFTuW2Naz{?4#c
zlr+TPzSZk5@_K9OMO_yy`&PF*TCS>@^HBD5d|4OXbnp92dkjLR0(5rL<f1T3xP<q}
z`CrgMu*)Pn^3S5B71qLuqVXcPWp8COzWJ+BX2NHipCzvRPPP@0NNS*tEOx&qU)uWj
z-)Cpr3-W3|g!}^V2DU(V5SR+o^rxM^XqUqDr9<_|DAMn@{7ultjzWH?wJit2N?~!J
z6M4e4@~F~F{pRwoZPf?>Y_oMlAoF0a00zJL*2`cxMEl3C$m(>Cz7dQGi+r&F{y2XZ
z)okbje^u$2t~ng+Qm9gNBza=mdnkn^(!ct)urC=1%Fx({X{V{r^Z}Gu#b#|_+;1>J
z!yy!<BGdjYzmqhg&EWf>@u*3G+-Uu{$_N=Dz9#5!I&>6_Nct@otrOtb{saDZjSnp+
zpIQLItG%~E#BCBkB6O>J^yg4;ev1<6#~6K);@Y`)HrMS0>$d;k=1`>%?VeX>pB!N+
zbw=W20NrfFQ|}nP6%@pxglW7bPADtu2Nz2_#F;9KcgJD|Or}%M@e(dfoVwhdb-hAd
zt+3C&Oc5rk=-Lj(Z{)az*Qnq(o4!!Zj1AaBF@?glZt?1}m)b#d<Fx#`vSBZ`1fP=#
zSJ5dxtQj7avNm+CmoOHk&g1FcD;r9M_h`)s9lLaD7u6g3awrA>OG~{+$G<PE#xC^M
zj3&wT^5qUCYNaqj%vks2pJc<yj;<*Wvwm7S*RMypJpay)-W9$kA81V5T}Wrn8p+T~
z!7}pQ^_xGNTh=qtMZMXx)3jm4asMNukjYV2Y5kcV_~Psaqp{kee^|!v@VA4Fm2vp~
z9JeQ~={sGYFs3|+<{XzdpBe5I0tF@X%`D&5iyUg}$}w8$jL0+gCN@^{PrLsXIMVCv
zWEb~tO*k`R*m!?Cwh#;;XN=;-77hgyllgDeV88^2Tw+-l7|&jGc%y{Ny7ZZrz{yFF
z<pitwJwqDrf?LO6vcRo`6VJT;7_M5>d-GNmNx8mIg;C~G8=V|Z7@m$Nk5FX^K_w0j
z?zw1<f9))9o*Y|CKty#?{w{0AXtqq>WCcg)PR0u@@sm>DP1=3me9{9yy9gUY9S>f4
zvn;tYw)pc_a|yCtq)WNd8|eHfQlN;$NSje^bzovXdFpcI2g|JePv++Nr7Uk=ofwLv
zqSN~?d&1v*$<c^}!_S;GbPh~yL9{R0$0$VS^=FPc$@Jwi7jM8={&0k2M&RJ;xi>_I
zL;A|H`rPeFkqv3RyG|ZE(n&w760a3AhXw=H7h5kzBh9U-@)d#V`5y*beqOM?RDnyp
z>EfDgNorDInbtfwrDvsCzY{AI5D|CoPNwfW(9Txu)?WD*_y_l6l{0XD+XB{Q!F-OI
zQI)$vsIHJzCF=_*2YZ>mEq6hzz$Ct>|K@HB;o!azqU<~s))^&dsq!{qlSc>3$2q$O
zacUgny3S`p_sqmn=tM_EF+3|)@V)ycX<{&1OwdZAPjLSaYxZ_f{<uVWj+V1MC*2z7
z61G=zKi)Oj)nN{Oz89faxdx-EdpeM$F0d@=K>T;6>5W+%*Cj$M4`-HYfU(TL8Q8rS
zYKDiNKDA2{nrlpCNub}kDl{|5Ght8mcX%C7#-^5Y9f!QN!Mbepd%Ml@FS4x;tgOIH
z=`&6fj>WcxPbr1(ww^-FAOI!~EdcP$V*ty4iu(F#(+AK|p1)v3QVU~l0x){l&=oq)
GVgCag`uA7>

literal 0
HcmV?d00001