sparrowwallet/sparrow
1
0
Fork 0
mirror of https://github.com/sparrowwallet/sparrow.git synced 2024-12-25 05:06:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

don't initialise a ContextMenu for each cell update

Browse source
This commit is contained in:
wazint 2023-03-04 20:30:47 +02:00
parent 97b4ed48db
commit b9a553abf2
1 changed files with 17 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/main/java/com/sparrowwallet/sparrow/control/CoinCell.java
View file

@ -22,6 +22,7 @@ import java.text.DecimalFormat;
class CoinCell extends TreeTableCell<Entry, Number> implements ConfirmationsListener { class CoinCell extends TreeTableCell<Entry, Number> implements ConfirmationsListener {
private final CoinTooltip tooltip; private final CoinTooltip tooltip;
private final CoinContextMenu contextMenu;
private IntegerProperty confirmationsProperty; private IntegerProperty confirmationsProperty;
@ -29,6 +30,8 @@ class CoinCell extends TreeTableCell<Entry, Number> implements ConfirmationsList
super(); super();
tooltip = new CoinTooltip(); tooltip = new CoinTooltip();
tooltip.setShowDelay(Duration.millis(500)); tooltip.setShowDelay(Duration.millis(500));
contextMenu = new CoinContextMenu();
setContextMenu(contextMenu);
getStyleClass().add("coin-cell"); getStyleClass().add("coin-cell");
if(Platform.getCurrent() == Platform.OSX) { if(Platform.getCurrent() == Platform.OSX) {
getStyleClass().add("number-field"); getStyleClass().add("number-field");
@ -43,6 +46,7 @@ class CoinCell extends TreeTableCell<Entry, Number> implements ConfirmationsList
setText(null); setText(null);
setGraphic(null); setGraphic(null);
setTooltip(null); setTooltip(null);
setContextMenu(null);
} else { } else {
Entry entry = getTreeTableView().getTreeItem(getIndex()).getValue(); Entry entry = getTreeTableView().getTreeItem(getIndex()).getValue();
EntryCell.applyRowStyles(this, entry); EntryCell.applyRowStyles(this, entry);
@ -63,7 +67,8 @@ class CoinCell extends TreeTableCell<Entry, Number> implements ConfirmationsList
setText(satsValue); setText(satsValue);
} }
setTooltip(tooltip); setTooltip(tooltip);
setContextMenu(new CoinContextMenu(amount)); contextMenu.updateAmount(amount);
setContextMenu(contextMenu);
if(entry instanceof TransactionEntry transactionEntry) { if(entry instanceof TransactionEntry transactionEntry) {
tooltip.showConfirmations(transactionEntry.confirmationsProperty()); tooltip.showConfirmations(transactionEntry.confirmationsProperty());
@ -159,7 +164,17 @@ class CoinCell extends TreeTableCell<Entry, Number> implements ConfirmationsList
} }
private static class CoinContextMenu extends ContextMenu { private static class CoinContextMenu extends ContextMenu {
public CoinContextMenu(Number amount) { private Number amount;
public CoinContextMenu() {
}
public void updateAmount(Number amount) {
if (amount.equals(this.amount)) {
return;
}
this.amount = amount;
getItems().clear();
MenuItem copySatsValue = new MenuItem("Copy Value in sats"); MenuItem copySatsValue = new MenuItem("Copy Value in sats");
copySatsValue.setOnAction(AE -> { copySatsValue.setOnAction(AE -> {
hide(); hide();