various minor improvements

This commit is contained in:
Craig Raw 2023-07-05 09:48:48 +02:00
parent 795892f7c9
commit f980516462
3 changed files with 14 additions and 0 deletions

View file

@ -2,6 +2,9 @@ name: Package
on: workflow_dispatch
permissions:
contents: read
jobs:
build:
runs-on: ${{ matrix.os }}

View file

@ -646,6 +646,8 @@ public class ServerPreferencesController extends PreferencesDetailController {
reason += "\n\nSee https://sparrowwallet.com/docs/connect-node.html";
} else if(reason != null && (reason.startsWith("Cannot connect to hidden service"))) {
reason += " on the server. Check that the onion address and port are correct, and that both Tor and the Electrum server are running on the node. Usually SSL is not enabled, and the port is 50001.";
} else if(reason != null && (reason.startsWith("Cannot find Bitcoin Core cookie file at"))) {
reason += "\n\nMake sure server=1 has been added to bitcoin.conf";
}
testResults.setText("Could not connect:\n\n" + reason);

View file

@ -37,6 +37,7 @@ import tornadofx.control.Field;
import javax.smartcardio.CardException;
import java.net.URL;
import java.util.Base64;
import java.util.Locale;
import java.util.Optional;
import java.util.ResourceBundle;
import java.util.stream.Collectors;
@ -370,6 +371,14 @@ public class KeystoreController extends WalletFormController implements Initiali
selectSourcePane.setVisible(false);
Keystore importedKeystore = result.get();
if(keystore.getSource() == KeystoreSource.SW_SEED && importedKeystore.getSource() != KeystoreSource.SW_SEED) {
Optional<ButtonType> optType = AppServices.showWarningDialog("Confirm Replacement",
"You are replacing a software wallet with a " + importedKeystore.getSource().getDisplayName().toLowerCase(Locale.ROOT) + ", which will remove the seed. Are you sure?",
ButtonType.NO, ButtonType.YES);
if(optType.isPresent() && optType.get() == ButtonType.NO) {
return;
}
}
walletForm.getWallet().makeLabelsUnique(importedKeystore);
keystore.setSource(importedKeystore.getSource());
keystore.setWalletModel(importedKeystore.getWalletModel());