sparrowwallet/sparrow
1
0
Fork 0
mirror of https://github.com/sparrowwallet/sparrow.git synced 2025-11-05 11:56:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Satochip: add check pin size

Browse source
This commit is contained in:
Toporin 2023-09-06 21:08:27 +01:00
parent 5b203a6c61
commit fdc1186280
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/main/java/com/sparrowwallet/sparrow/io/satochip/SatochipCommandSet.java
View file

@ -129,6 +129,7 @@ public class SatochipCommandSet {
log.error("SATOCHIP: SatochipCommandSet cardTransmit() sw12==0x9C06: PIN required!"); log.error("SATOCHIP: SatochipCommandSet cardTransmit() sw12==0x9C06: PIN required!");
//TODO: throw? //TODO: throw?
//TODO: verify PIN? //TODO: verify PIN?
throw new RuntimeException("PIN required!");
} }
// SecureChannel is not initialized // SecureChannel is not initialized
else if (sw12==0x9C21){ else if (sw12==0x9C21){
@ -297,7 +298,11 @@ public class SatochipCommandSet {
} }
pin = this.pinCached; pin = this.pinCached;
} }
byte[] pinBytes = pin.getBytes(StandardCharsets.UTF_8); byte[] pinBytes = pin.getBytes(StandardCharsets.UTF_8);
if (pinBytes.length > 16){
throw new RuntimeException("PIN should be maximum 16 characters!");
}
APDUCommand capdu = new APDUCommand(0xB0, INS_VERIFY_PIN, (byte)pinNbr, 0x00, pinBytes); APDUCommand capdu = new APDUCommand(0xB0, INS_VERIFY_PIN, (byte)pinNbr, 0x00, pinBytes);
log.trace("SATOCHIP SatochipCommandSet cardVerifyPIN() capdu:"+ capdu.toHexString()); log.trace("SATOCHIP SatochipCommandSet cardVerifyPIN() capdu:"+ capdu.toHexString());